Extended settings.xml - Profiles with Repo#813
Open
Scyjin wants to merge 1 commit intoactions:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the generation of the Maven settings.xml file to support an additional custom repository alongside Maven Central. Key changes include:
- Adding new constants in src/constants.ts to handle repository configuration.
- Updating authentication and settings generation functions in src/auth.ts to inject repository parameters.
- Documenting the new repository configuration and inputs in docs/advanced-usage.md and action.yml.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/constants.ts | New constants added to support custom repository parameters. |
| src/auth.ts | Updated functions to process repository configuration, including profile fallback. |
| docs/advanced-usage.md | Extended documentation to explain repository configuration usage. |
| action.yml | Added new input definitions for repository settings. |
Comments suppressed due to low confidence (1)
src/auth.ts:146
- Add tests to verify that the settings.xml is correctly generated when repository configuration parameters are provided, ensuring that the profiles are included or omitted as intended.
profiles: repoId && profileId && repoUrl ? [profiles] : [],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building Maven Project with dependencies of another Repository then Maven-Central.
This could be extended to support more than one repo.
Also the profile could be cut down to one overall-profile, i think.
I'm more the Backend Guy, hope its ok. :)
Description:
Extended settings.xml generation to include another Repository.
This should provide nessecary Information while building with Maven.
So your build could refer to something like Artifacts in a private github repository.
Related issue:
Check list: